]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
appDisplay: Expand titles on keyboard focus as well
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Fri, 13 Nov 2020 17:35:29 +0000 (14:35 -0300)
committerFlorian Müllner <fmuellner@gnome.org>
Fri, 13 Nov 2020 23:29:14 +0000 (23:29 +0000)
In addition to hover, expand wrapped app titles when keyboard
focus is in as well. This gives keyboard users a chance to
read the app name.

Related: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3333

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1496

js/ui/appDisplay.js

index 9c09a84c97a2811450c445b9ceebbcf54e6d4986..ab4bb6c863df02943c298f9a2c9983613c426ed1 100644 (file)
@@ -1512,15 +1512,15 @@ class AppViewItem extends St.Button {
             label.disconnect(id);
         });
 
-        const { hover } = this;
+        const expand = this.hover || this.has_key_focus();
         label.save_easing_state();
-        label.set_easing_duration(hover
+        label.set_easing_duration(expand
             ? APP_ICON_TITLE_EXPAND_TIME
             : APP_ICON_TITLE_COLLAPSE_TIME);
         clutterText.set({
-            line_wrap: hover,
-            line_wrap_mode: hover ? Pango.WrapMode.WORD_CHAR : Pango.WrapMode.NONE,
-            ellipsize: hover ? Pango.EllipsizeMode.NONE : Pango.EllipsizeMode.END,
+            line_wrap: expand,
+            line_wrap_mode: expand ? Pango.WrapMode.WORD_CHAR : Pango.WrapMode.NONE,
+            ellipsize: expand ? Pango.EllipsizeMode.NONE : Pango.EllipsizeMode.END,
         });
     }
 
@@ -1608,6 +1608,16 @@ class AppViewItem extends St.Button {
             x > this.width - IconGrid.RIGHT_DIVIDER_LEEWAY;
     }
 
+    vfunc_key_focus_in() {
+        this._updateMultiline();
+        super.vfunc_key_focus_in();
+    }
+
+    vfunc_key_focus_out() {
+        this._updateMultiline();
+        super.vfunc_key_focus_out();
+    }
+
     handleDragOver(source, _actor, x) {
         if (source === this)
             return DND.DragMotionResult.NO_DROP;